smengcl commented on code in PR #5440:
URL: https://github.com/apache/ozone/pull/5440#discussion_r1364900963
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3515,9 +3519,19 @@ public S3VolumeContext getS3VolumeContext() throws
IOException {
}
}
- // getVolumeInfo() performs acl checks and checks volume existence.
+
+ final OmVolumeArgs volumeInfo;
+ if (skipChecks) {
+ // for internal usages, skip acl checks and metrics.
+ volumeInfo = volumeManager.getVolumeInfo(s3Volume);
+ } else {
+ // if external usages, getVolumeInfo() performs acl checks
+ // and update metrics.
Review Comment:
```suggestion
// for external usages, getVolumeInfo() performs acl checks
// and metric updates.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
