sumitagrawl commented on code in PR #5446:
URL: https://github.com/apache/ozone/pull/5446#discussion_r1366796052
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -197,18 +196,21 @@ public ContainerStateMachine(RaftGroupId gid,
ContainerDispatcher dispatcher,
metrics = CSMMetrics.create(gid);
this.writeChunkFutureMap = new ConcurrentHashMap<>();
applyTransactionCompletionMap = new ConcurrentHashMap<>();
- int numPendingRequests = conf
- .getObject(DatanodeRatisServerConfig.class)
- .getLeaderNumPendingRequests();
long pendingRequestsBytesLimit = (long)conf.getStorageSize(
OzoneConfigKeys.DFS_CONTAINER_RATIS_LEADER_PENDING_BYTES_LIMIT,
OzoneConfigKeys.DFS_CONTAINER_RATIS_LEADER_PENDING_BYTES_LIMIT_DEFAULT,
StorageUnit.BYTES);
- int pendingRequestsMegaBytesLimit =
- HddsUtils.roundupMb(pendingRequestsBytesLimit);
- stateMachineDataCache = new ResourceLimitCache<>(new ConcurrentHashMap<>(),
- (index, data) -> new int[] {1, HddsUtils.roundupMb(data.size())},
- numPendingRequests, pendingRequestsMegaBytesLimit);
+ // cache with FIFO eviction, and if element not found, this needs
+ // to be obtained from disk for slow follower
+ stateMachineDataCache = new ResourceCache<>(
+ (index, data) -> HddsUtils.roundupKb(((ByteString)data).size()),
Review Comment:
ok, removed roundup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
