adoroszlai commented on PR #5404: URL: https://github.com/apache/ozone/pull/5404#issuecomment-1772602884
@fapifta thanks for checking. Acceptance test scripts are placed in directories based on the environment they run in. `ozonesecure` is non-HA with security enabled. Test scripts are executed in one of the splits, which is defined by this line: https://github.com/apache/ozone/blob/3d73fd98d851afd9f0e61c0b67300b051ce9b1d5/hadoop-ozone/dist/src/main/compose/ozonesecure/test-public-key-cert-recovery.sh#L18 We can tweak overall CI time by changing the suite, either to another existing one, or even to a new one. (see #5467 for the most recent such tweak) The `cert-rotation` suite is currently very quick, since it doesn't have many tests, and root CA rotation test in HA environment is disabled due to flakiness. It was created initially to localize frequent failures in these tests, as it is quicker to re-run only this part than the entire secure split. > so we initialize 5 docker environments just to run the secure tests already You are right, starting the environment takes time. I would recommend adding separate test script only if extra nodes and/or cluster settings are required. This is indicated by the definition of `COMPOSE_FILE`, which is used to mix in other yaml files. If this public key recovery test can be executed in the same cluster as some other existing test, we can save some time by moving it to that script. As far as I see, all existing test scripts in the `cert-rotation` suite use some extra configs, so it may not be possible to merge this new script into another one. When merging test scripts, to make code more manageable, we can still use separate scripts to define the tests (not named `test-X.sh`, rather `X-tests.sh` or similar, to avoid getting executed directly), and then only `source` them in the actual test script. See `test-ec.sh` for an example of that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
