[
https://issues.apache.org/jira/browse/HDDS-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hemant Kumar updated HDDS-9382:
-------------------------------
Description:
As part of initial implementation of RocksDBCheckpointingDiffer, snapshotID was
added to
[CompactionNode|https://github.com/apache/ozone/pull/3824/files#diff-1d5c6c892a2d24d85ca002dafcb9f39341192baaa7b5323d2325b5fc7a238c7fR246]
for debugging. Now in [change#5317|https://github.com/apache/ozone/pull/5317],
we migrated to RocksDB to store it and also keep DB {*}transactionId{*}. The
other problem is how to get {*}snapshotId{*}. You can argue and use
*snapshotChainManager* but it will create circular dependency unless setter is
used (which is not a nice way).
Hence as part of this jira, we can remove *snapshotId* from the compaction log
and just rely on {*}transactionId{*}.
was:
As part of initial implementation of RocksDBCheckpointingDiffere, snapshotID
was added to
[CompactionNode|https://github.com/apache/ozone/pull/3824/files#diff-1d5c6c892a2d24d85ca002dafcb9f39341192baaa7b5323d2325b5fc7a238c7fR246]
for debugging. Now in [change#5317|https://github.com/apache/ozone/pull/5317],
we migrated to RocksDB to store it and also keep DB *transactionId*. The other
problem is how to get *snapshotId*. You can argue and use
*snapshotChainManager* but it will create circular dependency unless setter is
used (which is not a nice way).
Hence as part of this jira, we can remove *snapshotId* from the compaction log
and just rely on *transactionId*.
> Clean up: Remove snapshotId from compaction DAG
> ------------------------------------------------
>
> Key: HDDS-9382
> URL: https://issues.apache.org/jira/browse/HDDS-9382
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Hemant Kumar
> Assignee: Amita Shukla
> Priority: Major
> Labels: newbie, pull-request-available
>
> As part of initial implementation of RocksDBCheckpointingDiffer, snapshotID
> was added to
> [CompactionNode|https://github.com/apache/ozone/pull/3824/files#diff-1d5c6c892a2d24d85ca002dafcb9f39341192baaa7b5323d2325b5fc7a238c7fR246]
> for debugging. Now in
> [change#5317|https://github.com/apache/ozone/pull/5317], we migrated to
> RocksDB to store it and also keep DB {*}transactionId{*}. The other problem
> is how to get {*}snapshotId{*}. You can argue and use *snapshotChainManager*
> but it will create circular dependency unless setter is used (which is not a
> nice way).
> Hence as part of this jira, we can remove *snapshotId* from the compaction
> log and just rely on {*}transactionId{*}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
