sadanand48 commented on code in PR #5473:
URL: https://github.com/apache/ozone/pull/5473#discussion_r1367356574
##########
.github/workflows/intermittent-test-check.yml:
##########
@@ -137,7 +137,8 @@ jobs:
CHECK: ${{ needs.prepare-job.outputs.test_type }}
- name: Summary of failures
run: hadoop-ozone/dev-support/checks/_summary.sh target/${{
needs.prepare-job.outputs.test_type }}/summary.txt
- if: always()
+ if: ${{ !cancelled() }}
+ continue-on-error: ${{ github.event.inputs.fail-fast != 'true' }}
Review Comment:
Can we fail the split step too instead of passing it in case of fail-fast =
false. Just for better optics, If I look at the fail-fast = false run in the PR
description, it looks like the Count Failure step failed but actually it failed
the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
