adoroszlai commented on code in PR #5483:
URL: https://github.com/apache/ozone/pull/5483#discussion_r1369759607
##########
.github/pull_request_template.md:
##########
@@ -1,12 +1,12 @@
## What changes were proposed in this pull request?
+(Provide a one-liner summary of the changes in the **PR Title** field above.)
(Please fill in changes proposed in this fix
Review Comment:
```suggestion
Please describe your PR in detail:
```
##########
.github/pull_request_template.md:
##########
@@ -1,12 +1,12 @@
## What changes were proposed in this pull request?
+(Provide a one-liner summary of the changes in the **PR Title** field above.)
(Please fill in changes proposed in this fix
-1. **Title:** Title should provide a one sentence overview of the purpose of
the PR.
-2. **Description:**
+1. **Description:**
* What changes are proposed in the PR? and Why? It would be better if it is
written from third person's perspective not just for the reviewer.
* Provide as much context and rationale for the pull request as possible.
It could be copy-paste from the Jira's description if the jira is well defined.
* If it is complex code, describe the approach used to solve the issue. If
possible attach design doc, issue investigation, github discussion, etc.
-3. **PR examples:** [PR#3980](https://github.com/apache/ozone/pull/3980),
[PR#5265](https://github.com/apache/ozone/pull/5265),
[PR#4701](https://github.com/apache/ozone/pull/4701),
[PR#5283](https://github.com/apache/ozone/pull/5283),
[PR#5300](https://github.com/apache/ozone/pull/5300))
+2. **PR examples:** [PR#3980](https://github.com/apache/ozone/pull/3980),
[PR#5265](https://github.com/apache/ozone/pull/5265),
[PR#4701](https://github.com/apache/ozone/pull/4701),
[PR#5283](https://github.com/apache/ozone/pull/5283),
[PR#5300](https://github.com/apache/ozone/pull/5300))
Review Comment:
```suggestion
Examples of well-written pull requests:
* #3980
* #5265
* #4701
* #5283
* #5300
```
##########
.github/pull_request_template.md:
##########
@@ -1,12 +1,12 @@
## What changes were proposed in this pull request?
+(Provide a one-liner summary of the changes in the **PR Title** field above.)
(Please fill in changes proposed in this fix
-1. **Title:** Title should provide a one sentence overview of the purpose of
the PR.
-2. **Description:**
+1. **Description:**
Review Comment:
```suggestion
```
##########
.github/pull_request_template.md:
##########
@@ -1,12 +1,12 @@
## What changes were proposed in this pull request?
+(Provide a one-liner summary of the changes in the **PR Title** field above.)
Review Comment:
```suggestion
Provide a one-liner summary of the changes in the **PR Title** field above.
It should be in the form of `HDDS-1234. Short summary of the change`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
