adoroszlai commented on code in PR #5481:
URL: https://github.com/apache/ozone/pull/5481#discussion_r1372620962
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java:
##########
@@ -326,9 +326,11 @@ private void processCmd(DeleteCmdInfo cmd) {
DeletedContainerBlocksSummary summary =
DeletedContainerBlocksSummary.getFrom(containerBlocks);
- LOG.info("Start to delete container blocks, TXIDs={}, "
+ LOG.debug("Start to delete container blocks, TXIDs={}",
+ summary.getTxIDSummary());
Review Comment:
```suggestion
if (LOG.isDebugEnabled()) {
LOG.debug("Start to delete container blocks, TXIDs={}",
summary.getTxIDSummary());
}
```
We should keep `if (LOG.isDebugEnabled())` in this case. `getTxIDSummary()`
performs quite a bit of stream/string processing, which we would like to avoid
if the log is going to be discarded.
https://github.com/apache/ozone/blob/47f472f866be980ae17ca68387da85a0771c03c0/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DeletedContainerBlocksSummary.java#L93-L98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
