[ 
https://issues.apache.org/jira/browse/HDDS-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779767#comment-17779767
 ] 

Attila Doroszlai commented on HDDS-9500:
----------------------------------------

Thanks [~raju.balpande] for the question about timeout rule.  Since the timeout 
rule applies to all tests, please add it at the class level.  Example:

{code:title=https://github.com/apache/ozone/blob/f2db9cebbaa496d90ba3dcbce77d8ae484b106ee/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestMiniOzoneCluster.java#L60-L61}
@Timeout(300)
public class TestMiniOzoneCluster {
{code}

Changing {{ExpectedException}} to {{assertThrows}} is a good finding.

> Migrate simple tests in ozone-client to JUnit5
> ----------------------------------------------
>
>                 Key: HDDS-9500
>                 URL: https://issues.apache.org/jira/browse/HDDS-9500
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Attila Doroszlai
>            Assignee: Raju Balpande
>            Priority: Major
>
> Migrate the following test classes to JUnit5. See parent task for details.
> {code}
> hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/TestHddsClientUtils.java
> hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/TestOzoneClient.java
> hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/TestOzoneECClient.java
> hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/checksum/TestReplicatedBlockChecksumComputer.java
> hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/checksum/TestReplicatedFileChecksumHelper.java
> hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/io/TestECBlockOutputStreamEntry.java
> hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/io/TestKeyInputStreamEC.java
> hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneKMSUtil.java
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to