adoroszlai commented on code in PR #5427:
URL: https://github.com/apache/ozone/pull/5427#discussion_r1372234209
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/TestCleanupTableInfo.java:
##########
@@ -132,7 +133,9 @@ public void setupOzoneManagerMock()
invocationOnMock -> {
Pair<String, String> pair =
Pair.of(TEST_VOLUME_NAME, TEST_BUCKET_NAME);
Review Comment:
`pair` is no longer used. (And removing it will make `import ...Pair`
unused, too.)
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManager.java:
##########
@@ -65,7 +65,8 @@ public interface KeyManager extends OzoneManagerFS, IOzoneAcl
{
* @return a OmKeyInfo instance client uses to talk to container.
* @throws IOException
*/
- OmKeyInfo lookupKey(OmKeyArgs args, String clientAddress) throws IOException;
+ OmKeyInfo lookupKey(OmKeyArgs args, BucketLayout bucketLayout,
Review Comment:
Passing `BucketLayout` to `lookupKey`/`getKeyInfo` seems strange to me. I
would prefer passing `OmBucketInfo` (or `ResolvedBucket` if more convenient)
instead:
1. to hide the implementation detail that we need `bucketLayout` for some
internal logic
2. make future changes easier, should we need another bucket property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
