Galsza opened a new pull request, #5525:
URL: https://github.com/apache/ozone/pull/5525

   ## What changes were proposed in this pull request?
   Fix the failure in TestRootCaRotationPoller arising from multi threaded 
execution
   
   Please describe your PR in detail:
   Sometimes the test cases were failing because 
`CompletableFuture.supplyAsync()` wasn't finishing before assertions were made 
for its results. Now 2 test cases avoid using the future at all, the third one 
is refactored so that it can wait for its result.
   
   There is also a small refactor regarding pollRootCas, its visibility is 
changed so that it can be called directly from the test instead of relying on 
the run method that would introduce another point of possible sync issue via 
the executorService scheduling.
   
   And finally pollRootCas now returns weather it found new certificates. Also 
added some logging in the success scenario.
   
   The error `Exception in thread "RootCaRotationPoller" 
java.lang.OutOfMemoryError: GC overhead limit exceeded` mentioned in the Jira 
ticked was unrelated, its was caused by my local environment. (IntelliJ tried 
storing all test results on the heap)
   
   ## How was this patch tested?
   
   Run each test locally 1000 times. I will add additional CI runs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to