ChenSammi commented on code in PR #5524:
URL: https://github.com/apache/ozone/pull/5524#discussion_r1378488847
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java:
##########
@@ -555,6 +565,12 @@ public synchronized void close() throws IOException {
if (!isException) {
Preconditions.checkArgument(writeOffset == offset);
}
+ if (requiresAtomicWrite) {
+ long expectedSize = blockOutputStreamEntryPool.getDataSize();
+ Preconditions.checkArgument(expectedSize == offset,
Review Comment:
Suggest to use Preconditions.checkState here, so it will throw out
IllegalStateException instead of
IllegalArgumentException. IllegalStateException is more appropriate than
IllegalArgumentException here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
