ivandika3 commented on PR #5534: URL: https://github.com/apache/ozone/pull/5534#issuecomment-1790257680
@guohao-rosicky Thank you for the patch. I saw a lot of similar issues where a request wanted to update certain attributes from a entity, but forget some properties, causing these forgotten properties to be unset. I think it would be better if the solution is similar @sumitagrawl 's HDDS-9110 (https://github.com/apache/ozone/pull/5138) where it uses `OmBucketInfo.toBuilder` from the existing `OmBucketInfo` and only. We can introduce similar method `OmKeyInfo.toBuilder` which take the existing `OmKeyInfo` and update the relevant properties from there. So in the future, if we add more properties, we can just update `OmKeyinfo.toBuilder` to include the new property. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
