devmadhuu commented on code in PR #4245:
URL: https://github.com/apache/ozone/pull/4245#discussion_r1380330596
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java:
##########
@@ -101,6 +105,11 @@ public Pair<String, Boolean> process(OMUpdateEventBatch
events) {
} else {
LOG.error("processWithFSO failed.");
}
+ if (success) {
Review Comment:
Pls check if it is really necessary this dependency of success on one
another ?
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java:
##########
@@ -121,6 +130,8 @@ public Pair<String, Boolean> reprocess(OMMetadataManager
omMetadataManager) {
.reprocessWithFSO(omMetadataManager));
tasks.add(() -> nsSummaryTaskWithLegacy
.reprocessWithLegacy(reconOMMetadataManager));
+ tasks.add(() -> nsSummaryTaskWithOBS
+ .reprocessWithOBS(reconOMMetadataManager));
List<Future<Boolean>> results;
ExecutorService executorService = Executors
Review Comment:
We can think of increasing the fixed number of threads to 3, if want to run
in parallel, but this may back fire as well because resources in recon are
limited, however it will be good if we can analyse and test the resource usage
with minimum of 10 million add key events or test with limited number of events
depending on availability of system resources to have an idea how Recon will
perform. Else after finishing of previous 2 tasks, this OBS taks will run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
