sodonnel commented on code in PR #5527:
URL: https://github.com/apache/ozone/pull/5527#discussion_r1380684438
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/LegacyReplicationManager.java:
##########
@@ -499,6 +499,19 @@ protected void processContainer(ContainerInfo container,
return;
}
+ // If the container is empty and has no replicas, it is possible it was
+ // a container which stuck in the closing state which never got any
+ // replicas created on the datanodes. In this case, we don't have
enough
+ // information to delete the container, so we just log it as EMPTY,
+ // leaving it as CLOSED and return true, otherwise, it will end up
+ // marked as missing by the under replication handling.
+ if (replicas.isEmpty()
+ && container.getState() == LifeCycleState.CLOSED
+ && container.getNumberOfKeys() == 0) {
+ report.incrementAndSample(HealthState.EMPTY,
container.containerID());
Review Comment:
I added the debug message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
