Tejaskriya commented on code in PR #5520:
URL: https://github.com/apache/ozone/pull/5520#discussion_r1381174393
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/interfaces/BlockManager.java:
##########
@@ -34,31 +34,30 @@ public interface BlockManager {
* Puts or overwrites a block.
*
* @param container - Container for which block need to be added.
- * @param data - Block Data.
+ * @param data - Block Data.
* @return length of the Block.
- * @throws IOException
*/
long putBlock(Container container, BlockData data) throws IOException;
/**
* Puts or overwrites a block.
*
* @param container - Container for which block need to be added.
- * @param data - Block Data.
- * @param incrKeyCount - Whether to increase container key count.
+ * @param data - Block Data.
+ * @param endOfBlock - The last putBlock call for this block (when
+ * all the chunks are written and stream is closed)
* @return length of the Block.
- * @throws IOException
*/
- long putBlock(Container container, BlockData data, boolean incrKeyCount)
+ long putBlock(Container container, BlockData data, boolean endOfBlock)
throws IOException;
/**
* Gets an existing block.
*
- * @param container - Container from which block need to be get.
+ * @param container - Container from which block needs to be fetched.
* @param blockID - BlockID of the Block.
* @return Block Data.
- * @throws IOException
+ * @throws StorageContainerException when BcsId is unknown or mismatched
*/
BlockData getBlock(Container container, BlockID blockID)
throws IOException;
Review Comment:
Thank you for the review! I have changed it, Please check if it is fine now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
