szetszwo commented on code in PR #5522:
URL: https://github.com/apache/ozone/pull/5522#discussion_r1382435781
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/utils/BufferUtils.java:
##########
@@ -39,8 +39,8 @@ private BufferUtils() {
* @param totalLen total length of all ByteBuffers
* @param bufferCapacity max capacity of each ByteBuffer
*/
- public static ByteBuffer[] assignByteBuffers(long totalLen,
- long bufferCapacity) {
+ public static ByteBuffer[] assignByteBuffers(int totalLen,
Review Comment:
The `totalLen` and `buffersAllocated` should be long. We should allow >= 2G
chunks/files.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/utils/BufferUtils.java:
##########
@@ -39,8 +39,8 @@ private BufferUtils() {
* @param totalLen total length of all ByteBuffers
* @param bufferCapacity max capacity of each ByteBuffer
*/
- public static ByteBuffer[] assignByteBuffers(long totalLen,
- long bufferCapacity) {
+ public static ByteBuffer[] assignByteBuffers(int totalLen,
Review Comment:
The `totalLen` and `buffersAllocated` should be long. We should allow >=
2GB chunks/files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
