ChenSammi commented on code in PR #5539:
URL: https://github.com/apache/ozone/pull/5539#discussion_r1386752907


##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/upgrade/UpgradeTask.java:
##########
@@ -64,6 +64,9 @@ public class UpgradeTask {
   private final DatanodeStoreSchemaThreeImpl datanodeStoreSchemaThree;
 
   private static final String BACKUP_CONTAINER_DATA_FILE_SUFFIX = ".backup";
+  public static final String MIGRATE_FLAG_FILE_NAME = "migrate";
+  public static final String UPGRADE_LOCK_FILE_NAME = "upgrade.lock";

Review Comment:
   Can we use a consistent naming here? 
   Say UPGRADE_LOCK_FILE_NAME and UPGRADE_COMPLETE_FILE_NAME, since upgrade is 
used through out this feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to