raju-balpande commented on PR #5556: URL: https://github.com/apache/ozone/pull/5556#issuecomment-1804070923
Hi @adoroszlai , I see the earlier the access modifier for temporaryFolder in AbstractReconSqlDBTest was public. `public TemporaryFolder temporaryFolder = new TemporaryFolder();` which I modified to protected (more restricted) `protected Path temporaryFolder;` But the check-style error is showing it to be made to private. I further checked that the abstract class is extended by 14 classes which leads impact. <img width="946" alt="image" src="https://github.com/apache/ozone/assets/146973984/544bd976-f1d7-4757-884c-d5e682f2218c";> Please suggest if protected is acceptable to shall I make it private and introduce a getter method which lead the changes in all 14 sub-classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
