sodonnel commented on code in PR #5606:
URL: https://github.com/apache/ozone/pull/5606#discussion_r1393898863
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/HeartbeatEndpointTask.java:
##########
@@ -179,7 +179,7 @@ public EndpointStateMachine.EndPointStates call() throws
Exception {
addQueuedCommandCounts(requestBuilder);
SCMHeartbeatRequestProto request = requestBuilder.build();
if (LOG.isDebugEnabled()) {
Review Comment:
If we are changing this, we can remove the `if (LOG.isDebugEnabled()) {`
wrapping the debug statement and then change the debug statement to:
```
LOG.debug("Sending heartbeat message : {}", request);
```
Ie, remove the toString call, which will be called by the logging internals
only if debug is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
