ChenSammi commented on code in PR #5020:
URL: https://github.com/apache/ozone/pull/5020#discussion_r1396641824
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java:
##########
@@ -296,7 +320,10 @@ private OMResponse submitRequestDirectlyToOM(OMRequest
request) {
ExitUtils.terminate(1, errorMessage, ex, LOG);
Thread.currentThread().interrupt();
}
- return omClientResponse.getOMResponse();
+ OMLockDetails omLockDetails = omClientResponse.getOmLockDetails();
Review Comment:
I see. Can we extract the "call.getProcessingDetails().add" logic to an
individual function, can call it directly here? to avoid generate a new
OMResponse to set omLockDetails.toProtobufBuilder().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
