[ 
https://issues.apache.org/jira/browse/HDDS-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788249#comment-17788249
 ] 

Tsz-wo Sze commented on HDDS-9697:
----------------------------------

Similarly, the StateMachine methods other than startTransaction(..) should not 
verify token. The fix has taken care all the cases:
 - 
[https://github.com/apache/ozone/blob/62508ed29143e5f04ddf229e37bf2a073acc10e9/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/DispatcherContext.java#L94-L104]

> ContainerStateMachine.applyTransaction(..) should not validate token again
> --------------------------------------------------------------------------
>
>                 Key: HDDS-9697
>                 URL: https://issues.apache.org/jira/browse/HDDS-9697
>             Project: Apache Ozone
>          Issue Type: Bug
>          Components: Ozone Datanode
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.4.0
>
>
> In ContainerStateMachine, the startTransaction(..) method has already 
> validated the token.  The applyTransaction(..) should not validate the same 
> token again.
> A problem is that the token may expire later on.  Then, a server may not be 
> able to re-apply the same transaction when replaying the RaftLog after server 
> restart.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to