adoroszlai commented on PR #5616: URL: https://github.com/apache/ozone/pull/5616#issuecomment-1821319709
Thanks @raju-balpande for updating the patch. There are a few JUnit4 assertions left in s3gateway: ``` hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java 59:import static org.junit.Assert.assertEquals; 60:import static org.junit.Assert.assertTrue; 61:import static org.junit.Assert.fail; hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/TestAuthorizationFilter.java 50:import static org.junit.Assert.fail; 53:import org.junit.Assert; hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/exception/TestOS3Exceptions.java 21:import static org.junit.Assert.assertEquals; ``` If the PR replaced these, too, then you could also add the `<allow.junit4>false` property to ban the old version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
