adoroszlai commented on code in PR #5648:
URL: https://github.com/apache/ozone/pull/5648#discussion_r1400930807
##########
hadoop-ozone/ozonefs-common/pom.xml:
##########
Review Comment:
Can you please also add `<allow.junit4>false</allow.junit4>` in
`<properties>`?
##########
hadoop-ozone/ozonefs-common/src/test/java/org/apache/hadoop/fs/ozone/TestBasicOzoneFileSystems.java:
##########
@@ -35,63 +34,59 @@
import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_SCM_BLOCK_SIZE;
import static
org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_SCM_BLOCK_SIZE_DEFAULT;
import static org.apache.hadoop.ozone.OzoneConsts.OM_SNAPSHOT_INDICATOR;
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Matchers.any;
/**
* Unit test for Basic*OzoneFileSystem.
*/
-@RunWith(Parameterized.class)
public class TestBasicOzoneFileSystems {
-
- private final FileSystem subject;
-
- @Parameterized.Parameters
public static Collection<Object[]> data() {
return Arrays.asList(
new Object[]{new BasicOzoneFileSystem()},
new Object[]{new BasicRootedOzoneFileSystem()}
);
}
Review Comment:
We can improve type safety here by removing the `Object[]` wrapper, which
was necessary for JUnit4.
```suggestion
public static Collection<FileSystem> data() {
return Arrays.asList(
new BasicOzoneFileSystem(),
new BasicRootedOzoneFileSystem()
);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
