aierate commented on PR #5646: URL: https://github.com/apache/ozone/pull/5646#issuecomment-1822221522
> > Hello @aierate. > > Some things: > > > > * One thing I notice is that the default value for the pagination is blank as attached in your screenshot. > > Can we fix that to have a default value of 1? > > * Also I tested this out locally, it seems like clicking the pagination works - as in the page changes, however in the dropdown it doesn't update the page number. So it stays blank irrespective of which page it jumped to. > > > > * This might happen because currentPage on `this` scope is becoming `undefined` it seems. And since undefined is not a part of any of the returned values by `getPagesArray()` which is being used in the it is being set as blank. Could you please look into this and fix that? > > > > Thanks a lot for working on this patch. > > Thank you very much @devabhishekpal for pointing out my bug. I solved this problem by adding (ng value="page") at rows 70 in scm-overview.html . Please help me review again, thank you. Here is UI screenshot. @devabhishekpal  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
