devmadhuu commented on PR #5645: URL: https://github.com/apache/ozone/pull/5645#issuecomment-1822782259
> Ran `TestOzoneManagerHAWithStoppedNodes` 500x both with and without the patch. > > On `master` it failed due to the index mismatch in 1 out of 500 runs. With the patch it didn't encounter this problem in any runs. > > However, with the patch, it timed out once waiting for OM to respond: > > ``` > at org.apache.hadoop.ozone.om.TestOzoneManagerHA.createKey(TestOzoneManagerHA.java:220) > at org.apache.hadoop.ozone.om.TestOzoneManagerHAWithStoppedNodes.testOMRatisSnapshot(TestOzoneManagerHAWithStoppedNodes.java:299) > ``` > > So in addition to the current change, I suggest moving the test method to `TestOzoneManagerHAWithAllRunning`. Thanks @adoroszlai for review, I have moved the test method to `TestOzoneManagerHAWithAllRunning` and re-ran both `TestOzoneManagerHAWithAllRunning` and `TestOzoneManagerHAWithStoppedNodes` with flaky workflow with 10x10 splits. https://github.com/devmadhuu/ozone/actions/runs/6956821061 https://github.com/devmadhuu/ozone/actions/runs/6956824996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
