[
https://issues.apache.org/jira/browse/HDDS-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789189#comment-17789189
]
Raju Balpande commented on HDDS-9691:
-------------------------------------
Covering some refactoring like:
{code:java}
try {
writer = new BufferedWriter(new OutputStreamWriter(
new FileOutputStream(file1), UTF_8));
writer.write(str);
} finally {
if (writer != null) {
writer.close();
}
} {code}
to
{code:java}
try(BufferedWriter writer1 = new BufferedWriter(new OutputStreamWriter(
new FileOutputStream(file1), UTF_8))) {
writer1.write(str);
} {code}
> Migrate remaining tests in ozone-recon to JUnit5
> ------------------------------------------------
>
> Key: HDDS-9691
> URL: https://issues.apache.org/jira/browse/HDDS-9691
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Raju Balpande
> Priority: Major
>
> Some tests missed in HDDS-9498 (they were present in earlier state of the PR):
> {code}
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconUtils.java
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/spi/impl/TestOzoneManagerServiceProviderImpl.java
> {code}
> and some files with leftover JUnit4 assertions:
> {code}
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/common/CommonUtils.java
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/OMMetadataManagerTestUtils.java
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/persistence/TestReconWithDifferentSqlDBs.java
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/scm/TestReconNodeManager.java
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/spi/impl/TestReconDBProvider.java
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestNSSummaryTask.java
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestNSSummaryTaskWithFSO.java
> hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestNSSummaryTaskWithLegacy.java
> {code}
> Finally, please ban JUnit4 usage by adding this property to
> {{hadoop-ozone/recon/pom.xml}}:
> {code}
> <allow.junit4>false</allow.junit4>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
