devmadhuu commented on code in PR #5612:
URL: https://github.com/apache/ozone/pull/5612#discussion_r1405591515


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -523,7 +523,8 @@ public boolean syncDataFromOM() {
             Thread.currentThread().interrupt();
           } catch (Exception e) {
             metrics.incrNumDeltaRequestsFailed();
-            LOG.warn("Unable to get and apply delta updates from OM.", e);
+            LOG.warn("Unable to get and apply delta updates from OM.",

Review Comment:
   > I have a question! Would it be a good idea to mention the 
`this.getClass().getName()` to over here, since the stack trace would not be 
printed?
   
   Whenever there is a log printed in logs, log4j always prints the class name 
from where this log has appeared, so I believe that is not needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to