[
https://issues.apache.org/jira/browse/HDDS-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790200#comment-17790200
]
Attila Doroszlai commented on HDDS-9773:
----------------------------------------
[~hemantk], using an abstract base class and two subclasses with minimal
content is fine. We just need to make sure they get executed. For that, I
think it's enough to convert the nested subclasses to top-level.
Alternatively, we can go back to the approach used in the first commit in the
original PR. As I mentioned, the PR was fine, until it was updated to address
a [comment|https://github.com/apache/ozone/pull/5518#discussion_r1388806291]
about volume/bucket being created for each test case. I think we can avoid
creating those by moving bucket creation to the {{@BeforeAll}} setup.
Having two subclasses doubles test setup time, while the per-method parameters
result in slightly more code duplication (of the {{@MethodSource}} annotation,
mostly).
For other test classes that need clusters configured differently, we can only
use the subclass-based approach (for now).
> TestOmSnapshotFileSystem is not run in CI
> -----------------------------------------
>
> Key: HDDS-9773
> URL: https://issues.apache.org/jira/browse/HDDS-9773
> Project: Apache Ozone
> Issue Type: Bug
> Components: test
> Affects Versions: 1.4.0
> Reporter: Attila Doroszlai
> Priority: Major
>
> HDDS-8201 migrated parameterized JUnit4 {{TestOmSnapshotFileSystem}} to
> JUnit5 by creating two subclasses. These are not executed, unless explicitly
> specified by {{-Dtest}}. (Search [latest [OM integration test
> run|https://github.com/apache/ozone/actions/runs/6969482597/job/18966184833#step:6:94]
> for {{TestOmSnapshotFileSystem}} to confirm.)
> [Initial
> patch|https://github.com/apache/ozone/pull/5518/files/e870ab0e84a01e3800d4a8fed7a4ad4005578fe6]
> in the [PR|https://github.com/apache/ozone/pull/5518] used a different
> approach and was [executed in
> CI|https://github.com/apache/ozone/actions/runs/6703326501/job/18214284130#step:6:190]
> fine.
> CC [~hemantk]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
