errose28 commented on code in PR #5670:
URL: https://github.com/apache/ozone/pull/5670#discussion_r1406738470
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/AbstractLayoutVersionManager.java:
##########
@@ -129,20 +129,18 @@ public void finalized(T layoutFeature) {
LOG.info("Finalization is complete.");
}
} else {
- String msgStart = "";
+ String versionMsg = "Software layout version: " + softwareLayoutVersion
+ + " Metadata layout version: " + metadataLayoutVersion
+ + " Feature Layout version: " + layoutFeature.layoutVersion();
+
if (layoutFeature.layoutVersion() <= metadataLayoutVersion) {
- msgStart = "Finalize attempt on a layoutFeature which has already "
- + "been finalized.";
+ LOG.warn("Finalize attempt on a layoutFeature which has already "
+ + "been finalized. " + versionMsg);
Review Comment:
Since this can happen normally maybe it should be an info message, and
explain that this is expected when Ratis logs are replayed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
