ashishkumar50 commented on code in PR #5661:
URL: https://github.com/apache/ozone/pull/5661#discussion_r1407436819
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java:
##########
@@ -222,6 +222,15 @@ public enum ChecksumCombineMode {
tags = ConfigTag.CLIENT)
private String fsDefaultBucketLayout = "FILE_SYSTEM_OPTIMIZED";
+ @Config(key = "incremental.chunk.list",
+ defaultValue = "false",
+ type = ConfigType.BOOLEAN,
+ description = "Client PutBlock request can choose incremental chunk " +
+ "list rather than full chunk list to optimize performance. " +
+ "Critical to HBase.",
+ tags = ConfigTag.CLIENT)
+ private boolean incrementalChunkList = false;
Review Comment:
This is not used in this, may be in client PR it can be included?
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java:
##########
@@ -89,18 +90,26 @@ public long putBlock(Container container, BlockData data)
throws IOException {
return putBlock(container, data, true);
}
+ @Override
+ public long putBlock(Container container, BlockData data, boolean endOfBlock)
+ throws IOException {
+ return putBlock(container, data, endOfBlock, true);
Review Comment:
By default can we keep incremental as false so that current behaviour
remains same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
