duongkame commented on PR #5625: URL: https://github.com/apache/ozone/pull/5625#issuecomment-1830420918
> I would suggest that if scm returns empty nodes; they are not added to the cache @kerneltime @adoroszlai @duongkame how do you think? The container cache is a read-through cache, meaning it loads data and adds to the cache on its own. This saves us the effort of maintaining things like key-level synchronization (to avoid double reads). However, guava does not provide the flexibility to filter/decide what not to put in the cache. The invalidation right after reads is the closest to get to the behavior we want, and it does it job just right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
