sadanand48 commented on code in PR #5703:
URL: https://github.com/apache/ozone/pull/5703#discussion_r1410156252
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java:
##########
@@ -292,25 +292,28 @@ public ContainerCommandResponseProto sendCommand(
Thread.currentThread().interrupt();
}
}
- try {
- for (Map.Entry<DatanodeDetails,
+ for (Map.Entry<DatanodeDetails,
CompletableFuture<ContainerCommandResponseProto> >
entry : futureHashMap.entrySet()) {
+ try {
responseProtoHashMap.put(entry.getKey(), entry.getValue().get());
- }
- } catch (InterruptedException e) {
- LOG.error("Command execution was interrupted.");
- // Re-interrupt the thread while catching InterruptedException
- Thread.currentThread().interrupt();
- } catch (ExecutionException e) {
- String message = "Failed to execute command {}.";
- if (LOG.isDebugEnabled()) {
- LOG.debug(message, processForDebug(request), e);
- } else {
- LOG.error(message + " Exception Class: {}, Exception Message: {}",
- request.getCmdType(), e.getClass().getName(), e.getMessage());
+ } catch (InterruptedException e) {
+ LOG.error("Command execution was interrupted.");
+ // Re-interrupt the thread while catching InterruptedException
+ Thread.currentThread().interrupt();
+ } catch (ExecutionException e) {
+ String message =
+ "Failed to execute command {} on datanode " + entry.getKey()
+ .getHostName();
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(message, processForDebug(request), e);
+ } else {
+ LOG.error(message + " Exception Class: {}, Exception Message: {}",
+ request.getCmdType(), e.getClass().getName(), e.getMessage());
+ }
}
}
+
Review Comment:
new line can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
