sumitagrawl commented on code in PR #5580:
URL: https://github.com/apache/ozone/pull/5580#discussion_r1410321900
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneFsDelete.java:
##########
@@ -139,10 +140,25 @@ protected void processPath(PathData item) throws
IOException {
if (moveToTrash(item) || !canBeSafelyDeleted(item)) {
return;
}
- if (!item.fs.delete(path, deleteDirs)) {
+ BasicRootedOzoneFileSystem.InnerDeleteResult innerDeleteResult = null;
+ if (item.fs.getUri().getScheme().equals(OZONE_OFS_URI_SCHEME)) {
+ BasicRootedOzoneFileSystem ofs = (BasicRootedOzoneFileSystem) item.fs;
Review Comment:
2 problem in this case,
1. BasicRootedOzoneFileSystem directly provide deleteKeys, not a part of
FileSystem interface, so this can not be extended
2. other URI type is not handled, like o3fs or others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
