adoroszlai commented on code in PR #5698: URL: https://github.com/apache/ozone/pull/5698#discussion_r1410418903
########## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestGetCommittedBlockLengthAndPutKey.java: ########## @@ -42,21 +42,26 @@ import org.apache.hadoop.ozone.OzoneConsts; import org.apache.hadoop.ozone.container.ContainerTestHelper; import org.apache.hadoop.ozone.container.common.SCMTestUtils; -import org.apache.ozone.test.tag.Flaky; +import org.apache.ozone.test.GenericTestUtils; import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Timeout; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; import static java.nio.charset.StandardCharsets.UTF_8; /** * Test Container calls. */ -@Timeout(300) +@Timeout(5000) Review Comment: If the flakiness is fixed by waiting at most 5 seconds in the test case, this increase of timeout seems unnnecessary. 5000 seconds is more than an hour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
