xichen01 commented on code in PR #5666:
URL: https://github.com/apache/ozone/pull/5666#discussion_r1410542795
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java:
##########
@@ -198,6 +201,13 @@ public List<AllocatedBlock> allocateBlock(
.allocateBlock(size, replicationConfig, owner, excludeList);
Review Comment:
maybe can add a new subclass for `PipelineChoosePolicy` (such as
`NearestPipelineChoosePolicy`) to "sort" the datanode when `choosePipeline`?
This would get a better results.
But this should be a new PR.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java:
##########
@@ -198,6 +201,13 @@ public List<AllocatedBlock> allocateBlock(
.allocateBlock(size, replicationConfig, owner, excludeList);
Review Comment:
Maybe can add a new subclass for `PipelineChoosePolicy` (such as
`NearestPipelineChoosePolicy`) to "sort" the datanode when `choosePipeline`?
This would get a better results.
But this should be a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
