adoroszlai opened a new pull request, #5707:
URL: https://github.com/apache/ozone/pull/5707
## What changes were proposed in this pull request?
Reduce code duplication:
* `TestBlockOutputStream` is duplicated as `TestBlockOutputStreamFlushDelay`
* `TestBlockOutputStreamWithFailures` is duplicated as
`TestBlockOutputStreamWithFailuresFlushDelay`
The main difference between the duplicates is that the ones without
`FlushDelay` set `OzoneClientConfig.setStreamBufferFlushDelay(false)`, while
the ones with `FlushDelay` rely on the default value for this property being
`true`.
Furthermore, `streamBufferFlushDelay` is a client-side config, so we can
completely merge `TestBlockOutputStream` and `TestBlockOutputStreamFlushDelay`
by:
* making test cases parameterized
* creating a new client for each test case
https://issues.apache.org/jira/browse/HDDS-9806
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7047698557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
