adoroszlai commented on code in PR #5718:
URL: https://github.com/apache/ozone/pull/5718#discussion_r1413193873
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/audit/AuditMessage.java:
##########
@@ -16,38 +16,33 @@
*/
package org.apache.hadoop.ozone.audit;
+import org.apache.hadoop.ozone.audit.AuditLogger.PerformanceStringBuilder;
import org.apache.logging.log4j.message.Message;
+import org.apache.ratis.util.MemoizedSupplier;
import java.util.Map;
+import java.util.function.Supplier;
/**
* Defines audit message structure.
*/
public final class AuditMessage implements Message {
-
- private final String message;
- private final String user;
- private final String ip;
+ private final transient Supplier<String> messageSupplier;
Review Comment:
Findbugs is really interesting. `AuditMessage` has been `Serializable` all
along, but suddenly it starts complaining about missing `serialVersionUID`:
```
M B SnVI: org.apache.hadoop.ozone.audit.AuditMessage is Serializable;
consider declaring a serialVersionUID At AuditMessage.java:[lines 29-125]
```
```suggestion
private static final long serialVersionUID = 1L;
private final transient Supplier<String> messageSupplier;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
