adoroszlai commented on PR #5710:
URL: https://github.com/apache/ozone/pull/5710#issuecomment-1838712751
Thanks @sadanand48 for updating the patch.
Now that I've tested it, I noticed that while the container is closing, we
may still get some ugly exceptions a few times, before finally getting
`Container ... already closed`:
```
com.google.protobuf.ServiceException:
org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.hdds.scm.exceptions.SCMException):
Cannot close a CLOSING container.
at
org.apache.hadoop.hdds.scm.server.SCMClientProtocolServer.closeContainer(SCMClientProtocolServer.java:669)
...
, while invoking $Proxy20.submitRequest over
nodeId=scmNodeId,nodeAddress=scm/172.19.0.8:9860. Trying to failover after
sleeping for 2000ms. Current retry count: 0.
...
Container 2 already closed
```
I also noticed that after `Container ... already closed`, the command exits
with error code.
I would like to suggest considering the following enhancements if possible:
1. show `Container ... already (CLOSING|CLOSED)` (only the actual state, not
both)
2. let the command exit successfully
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
