adoroszlai commented on PR #5516:
URL: https://github.com/apache/ozone/pull/5516#issuecomment-1839371870
@ronitsanan123 Please add `@SuppressWarnings("parameternumber")` as is, do
not replace `"parameternumber"` with 8 just because the constructor has 8
parameters.
Take a look at similar code:
https://github.com/apache/ozone/blob/a4bda5c6a2da921b53d02c622f1b9d14c190fb91/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java#L118-L124
Also, using more descriptive (but not excessively long) commit message for
each commit would be helpful (for both you and reviewers).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
