[ 
https://issues.apache.org/jira/browse/HDDS-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793037#comment-17793037
 ] 

Tsz-wo Sze commented on HDDS-9828:
----------------------------------

Here is a list of Files.createTempFile usages:
{code}
-- 
./hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/helpers/TestChunkUtils.java
 86:     Path tempFile = Files.createTempFile(PREFIX, "concurrent");
144:         Path path = Files.createTempFile(PREFIX, String.valueOf(i));
180:     Path tempFile = Files.createTempFile(PREFIX, "serial");
205:     Path tempFile = Files.createTempFile(PREFIX, "overwrite");
   4 occurrence(s)
-- 
./hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/security/symmetric/TestLocalKeyStore.java
 62:     testSecretFile = Files.createTempFile("key-strore-test", ".json");
   1 occurrence(s)
-- 
./hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestInterSCMGrpcProtocolService.java
103:     Path tempFile = Files.createTempFile(temp, CP_FILE_NAME, "");
   1 occurrence(s)
-- 
./hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFsSnapshot.java
266:     Path tempFile = Files.createTempFile("testFsLsSnapshot-", 
"any-suffix");
   1 occurrence(s)
-- 
./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotUtils.java
 86:     Path data = Files.createTempFile(DATA_PREFIX, DATA_SUFFIX);
   1 occurrence(s)
{code}


> Do not use Files.createTempFile in tests
> ----------------------------------------
>
>                 Key: HDDS-9828
>                 URL: https://issues.apache.org/jira/browse/HDDS-9828
>             Project: Apache Ozone
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz-wo Sze
>            Priority: Major
>
> Test file must be created under the test directory.  When using 
> Files.createTempFile, it could create files outside the test directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to