ivandika3 commented on code in PR #5725:
URL: https://github.com/apache/ozone/pull/5725#discussion_r1415395362
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java:
##########
@@ -703,11 +703,11 @@ private void handlePipelineFailure(RaftGroupId groupId,
}
triggerPipelineClose(groupId, msg,
- ClosePipelineInfo.Reason.PIPELINE_FAILED, false);
+ ClosePipelineInfo.Reason.PIPELINE_FAILED);
Review Comment:
Yes, you are right, I saw that
`ContainerStateMachine#notifyFollowerSlowness` will get triggered continuously
as long as the follower is still uncontactable by the leader. Thanks for
catching it.
I think we can have a deduplication logic to trigger heartbeat only for the
first `triggerPipelineClose` for that particular pipeline. Maybe a concurrent
set that stores the pipeline ID to be closed by SCM and the pipeline ID can be
removed from the set in `ClosePipelineCommandHandler` when SCM sends back the
pipeline close command.
Let me think about this further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
