[ 
https://issues.apache.org/jira/browse/HDDS-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793593#comment-17793593
 ] 

Raju Balpande commented on HDDS-9810:
-------------------------------------

While modifying the class 
`hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerIntegrityChecks.java`,

I noticed the constructor is been parameterized in two subclasses of it, which 
is not supported in Junit5.

We can not parameterize the constructor or setup method and Hence I 
parameterized the test methods in subclasses
 * 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerMetadataInspector.java
 * 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerCheck.java

I have to add one method returning the stream of `ContainerTestVersionInfo' for 
the supported format for tag `@methodSource`

> Migrate assertions in unit tests to JUnit5
> ------------------------------------------
>
>                 Key: HDDS-9810
>                 URL: https://issues.apache.org/jira/browse/HDDS-9810
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Attila Doroszlai
>            Assignee: Raju Balpande
>            Priority: Major
>
> Migrate assertions in the following test classes to JUnit5:
> {code}
> hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerIntegrityChecks.java
> hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/replication/TestSendContainerRequestHandler.java
> hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerReportHandler.java
> hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestIncrementalContainerReportHandler.java
> hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
> hadoop-hdds/test-utils/src/main/java/org/apache/ozone/test/GenericTestUtils.java
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to