raju-balpande opened a new pull request, #5738: URL: https://github.com/apache/ozone/pull/5738
## What changes were proposed in this pull request? Migrate assertions in the following test classes to JUnit5: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerIntegrityChecks.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/replication/TestSendContainerRequestHandler.java hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerReportHandler.java hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestIncrementalContainerReportHandler.java hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java hadoop-hdds/test-utils/src/main/java/org/apache/ozone/test/GenericTestUtils.java While modifying the class `hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerIntegrityChecks.java`, I noticed the constructor is been parameterized in two subclasses of it, which is not supported in Junit5. We can not parameterize the constructor or setup method and Hence I parameterized the test methods in subclasses - hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerMetadataInspector.java - hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerCheck.java I have to add one method returning the stream of `ContainerTestVersionInfo' for the supported format for tag `@methodSource`. The change included in - hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/ContainerTestVersionInfo.java ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-9810 ## How was this patch tested? Tested the code on system and in CI build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
