xichen01 commented on code in PR #5721:
URL: https://github.com/apache/ozone/pull/5721#discussion_r1417576798


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/interfaces/StorageLocationReportMXBean.java:
##########
@@ -33,6 +33,8 @@ public interface StorageLocationReportMXBean {
 
   long getRemaining();

Review Comment:
   I think this is because we include `commited` in the `remaining`, so when a 
Container is created, the space that the Container might use will be deducted 
from the `remaining`.
   
   If we don't include `commited` in the `remaining`, the problem is that the 
`datanode list` command shows that there is enough space remaining to create a 
Container, but in reality it is not possible to create a new Container, because 
inside the Datanode, the creation of a Container has to take into account 
`commited`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to