szetszwo commented on code in PR #5666:
URL: https://github.com/apache/ozone/pull/5666#discussion_r1417878358
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java:
##########
@@ -376,10 +382,11 @@ public List<DatanodeDetails> sortDatanodes(List<String>
nodes,
}
}
- private Node getDatanode(String clientMachine) {
+ private Node getClientDatanode(String clientMachine) {
Review Comment:
The client may not be running on a datanode. Let's call it `getClientNode`?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -1867,13 +1868,6 @@ private List<DatanodeDetails> sortDatanodes(String
clientMachine,
return sortedNodes;
}
- private static List<String> toNodeUuid(Collection<DatanodeDetails> nodes) {
- List<String> nodeSet = new ArrayList<>(nodes.size());
- for (DatanodeDetails node : nodes) {
- nodeSet.add(node.getUuidString());
- }
- return nodeSet;
- }
Review Comment:
Since `toNodeUuid ` is not longer needed in the new code, let's undo this
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
