adoroszlai commented on code in PR #5743:
URL: https://github.com/apache/ozone/pull/5743#discussion_r1418496524
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineProvider.java:
##########
@@ -18,12 +18,6 @@
package org.apache.hadoop.hdds.scm.pipeline;
-import java.io.IOException;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
-import java.util.stream.Collectors;
Review Comment:
Please avoid unnecessarily reordering imports. It creates noise in the
patch and, if merged, can cause conflicts for other changes (current PRs or
when backporting).
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineProvider.java:
##########
@@ -100,11 +100,10 @@ List<DatanodeDetails> pickNodesNotUsed(REPLICATION_CONFIG
replicationConfig,
"data in healthy node set. Nodes required: %d Found: %d",
metadataSizeRequired, dataSizeRequired, nodesRequired,
healthyDNsWithSpace.size());
- LOG.error(msg);
+ LOG.debug(msg);
Review Comment:
`pickNodesNotUsed` seems to be used only for RATIS/ONE pipeline. Similar
message is logged as error for RATIS/THREE pipeline elsewhere:
https://github.com/apache/ozone/blob/74de0705c916bb877eae44310f43a0d7069cdef9/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java#L280-L288
Can you please change that one, too? (Maybe even refactor to get rid of the
duplication.)
(copied from
https://github.com/apache/ozone/pull/5715#discussion_r1413138936)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
