ivandika3 commented on code in PR #5666:
URL: https://github.com/apache/ozone/pull/5666#discussion_r1418670350
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java:
##########
@@ -180,7 +180,7 @@ public Pipeline getPipeline() {
public void connect() throws Exception {
if (LOG.isDebugEnabled()) {
LOG.debug("Connecting to pipeline:{} datanode:{}", getPipeline().getId(),
- RatisHelper.toRaftPeerId(pipeline.getFirstNode()));
+ RatisHelper.toRaftPeerId(pipeline.getClosestNode()));
Review Comment:
Seems changing the `newRaftClient` primary datanode to the closest node
breaks the primary datanode assertions previously set on
https://github.com/apache/ratis/pull/945
Seems to fix this, we need to incorporate all the changes in
https://github.com/apache/ozone/pull/5414, essentially making it identical to
it.
We can incorporate all the datastream related changes here and close
https://github.com/apache/ozone/pull/5414, or we can revert to
`toRaftPeer(pipeline.getFirstNode())` first (with a TODO) and then address it
in https://github.com/apache/ozone/pull/5414 instead.
I'm going to revert it first since this PR is original suppose to focus on
passing client address to SCM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
