anuengineer commented on PR #921:
URL: https://github.com/apache/ozone/pull/921#issuecomment-1846039084

   > > Concise answer is that shape of code -- has meaning. The layout implies 
meaning and is the core artifact in comprehension. It is not line wrap, it is 
about crafting meaning in certain lay and text layout influences that.
   > 
   > @anuengineer I couldn't agree more. However, meaningful layout cannot be 
crafted in all cases with the current limit. Many times you are forced to break 
the natural flow at arbitrary locations. These unnatural breaks make code more 
difficult to understand.
   
   
   I agree. I am fully aware of the difficulties, and I am engaging on this 
topic. But there is a set of trade-offs, one of them most important ones is the 
consistency of the code base. The new code will have one shape and the old code 
will have another shape. A person might load this in the IDE -- @vivekratnavel  
correct me if I am wrong, and reformat old files, when I have change pending on 
it. How do we handle all that pain ? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to