xichen01 commented on code in PR #5745:
URL: https://github.com/apache/ozone/pull/5745#discussion_r1420568711
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java:
##########
@@ -113,6 +113,11 @@ public static void unregister() {
@Metric(about = "Ratis local command execution latency in nano seconds")
private MutableRate validateAndUpdateCacneLatencyNs;
+ @Metric(about = "average pagination for listKeys")
+ private MutableRate listKeysAveragePagination;
+
+ @Metric(about = "ops per second for listKeys")
+ private MutableRate listKeysOpsPerSec;
Review Comment:
We have the Latency metric `listKeysLatencyNs`, maybe we just need to add a
cumulative number of listKeys metric(such as: listKeysSize), which we can
calculate to get `listKeysOpsPerSec` and `listKeysAveragePagination`.
https://github.com/apache/ozone/blob/0e91b2aa81e32320f7922261fc209c1d8d91cf9b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java#L92-L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
