xichen01 commented on code in PR #4988:
URL: https://github.com/apache/ozone/pull/4988#discussion_r1421502127
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLog.java:
##########
@@ -88,14 +84,11 @@ void incrementCount(List<Long> txIDs)
int resetCount(List<Long> txIDs) throws IOException;
/**
- * Commits a transaction means to delete all footprints of a transaction
- * from the log. This method doesn't guarantee all transactions can be
- * successfully deleted, it tolerate failures and tries best efforts to.
- * @param transactionResults - delete block transaction results.
- * @param dnID - ID of datanode which acknowledges the delete block command.
+ * Get SCMDeletedBlockTransactionStatusManager.
+ * @return an Object of SCMDeletedBlockTransactionStatusManager
*/
- void commitTransactions(List<DeleteBlockTransactionResult>
transactionResults,
- UUID dnID);
+ SCMDeletedBlockTransactionStatusManager
+ getSCMDeletedBlockTransactionStatusManager();
Review Comment:
Removed the `getSCMDeletedBlockTransactionStatusManager` interface from
`DeletedBlockLog` and added `DeletedBlockTransactionStatusManager` related
actions to `DeletedBlockLog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
